https://mediawiki.comfac.net/index.php?action=history&feed=atom&title=Webshop-10-Feature-Gap-Cart-Discounts
Webshop-10-Feature-Gap-Cart-Discounts - Revision history
2026-06-05T11:03:07Z
Revision history for this page on the wiki
MediaWiki 1.45.1
https://mediawiki.comfac.net/index.php?title=Webshop-10-Feature-Gap-Cart-Discounts&diff=168&oldid=prev
Justinaquino: "Add all 14 Frappe ERPNext Webshop chapter pages from wikitext-upload"
2026-03-06T13:00:42Z
<p>"Add all 14 Frappe ERPNext Webshop chapter pages from wikitext-upload"</p>
<p><b>New page</b></p><div>= 10 - Feature Gap: Cart Discounts =<br />
<br />
'''Parent:''' [Webshop-Index Webshop Index] <br />
'''Previous:''' [Webshop-09-Hooks-and-Events 09 - Hooks & Events] <br />
'''Next:''' [Webshop-11-Feature-Plan-System-Builder 11 - Feature Plan: System Builder] <br />
'''Source:''' [https://github.com/Comfac-Global-Group/comfac-webshop/wiki/10-Feature-Gap-Cart-Discounts Comfac Webshop Wiki - Chapter 10]<br />
<br />
'''Status:''' 🔴 Not Implemented | '''Priority:''' High<br />
<br />
----<br />
<br />
== Problem Statement ==<br />
<br />
Discounts (from Pricing Rules, Coupon Codes, etc.) are calculated on the Quotation backend but are NOT displayed to the customer in the shopping cart UI. Customers see only the final price without understanding what promotions are active or how much they're saving.<br />
<br />
== Current State ==<br />
<br />
=== What the customer sees in the cart: ===<br />
<br />
- Item name, code, image<br />
- Quantity (editable)<br />
- Rate (final price per unit)<br />
- Amount (total for that line)<br />
- Net Total, Taxes, Grand Total<br />
- Coupon code badge (if applied)<br />
<br />
=== What exists on the Quotation but is HIDDEN: ===<br />
<br />
- Original price (<code>price_list_rate</code>) before discount<br />
- Discount percentage (<code>discount_percentage</code>)<br />
- Per-item discount amount<br />
- Total savings<br />
- Which pricing rules are active<br />
- Additional discount on total (<code>discount_amount</code>, <code>additional_discount_percentage</code>)<br />
<br />
== Where the Fix Needs to Happen ==<br />
<br />
=== 1. <code>cart_items.html</code> - Per-item discount display ===<br />
<br />
'''Current:''' Shows only <code>rate</code> and <code>amount</code><br />
'''Needed:''' Show <code>price_list_rate</code> struck through when it differs from <code>rate</code>, plus discount badge<br />
<br />
<pre>jinja2<br />
{% if item.price_list_rate and item.price_list_rate != item.rate %}<br />
<span class="original-price text-muted" style="text-decoration: line-through;"><br />
{{ item.get_formatted('price_list_rate') }}<br />
</span><br />
<span class="discount-badge text-success ml-1"><br />
-{{ item.discount_percentage }}%<br />
</span><br />
{% endif %}<br />
<pre><br />
<br />
=== 2. <code>cart_payment_summary.html</code> - Savings total ===<br />
<br />
'''Current:''' Net Total, Taxes, Grand Total only<br />
'''Needed:''' Add "You Save" row<br />
<br />
=== 3. <code>cart_items_total.html</code> - Pre-discount subtotal ===<br />
<br />
'''Current:''' Shows <code>doc.total</code> only<br />
'''Needed:''' Optionally show original total and savings<br />
<br />
=== 4. <code>cart_items_dropdown.html</code> - Navbar mini-cart ===<br />
<br />
'''Current:''' Shows <code>amount</code> only<br />
'''Needed:''' Strike-through price when discounted<br />
<br />
=== 5. Quotation DocType Modifications ===<br />
<br />
To "better reflect discounts" per the requirements:<br />
<br />
- Consider adding a '''child table or virtual field''' that summarizes all active pricing rules per item<br />
- Add a "Discount Summary" section to the Quotation print format<br />
- Potentially add <code>total_savings</code> as a computed field on Quotation<br />
<br />
== No Backend Changes Needed ==<br />
<br />
All discount data is already computed by ERPNext's pricing engine during:<br />
- <code>apply_cart_settings()</code> <br />
- <code>set_price_list_and_item_details()</code> <br />
- <code>calculate_taxes_and_totals()</code><br />
<br />
This is purely a '''frontend/template display issue'''.<br />
<br />
== Files to Modify ==<br />
<br />
{| class="wikitable"<br />
|-<br />
| File<br />
| Change<br />
|}<br />
|--------|----------|<br />
{| class="wikitable"<br />
|-<br />
| <code>templates/includes/cart/cart_items.html</code><br />
| Add original price, discount % display<br />
|-<br />
| <code>templates/includes/cart/cart_payment_summary.html</code><br />
| Add savings row, discount summary<br />
|-<br />
| <code>templates/includes/cart/cart_items_total.html</code><br />
| Add pre-discount total<br />
|-<br />
| <code>templates/includes/cart/cart_items_dropdown.html</code><br />
| Add strike-through price<br />
|-<br />
| <code>public/scss/webshop_cart.scss</code><br />
| Styles for discount badges, strike-through<br />
|}<br />
<br />
== Edge Cases to Handle ==<br />
<br />
1. '''Free items''' (<code>is_free_item=True</code>) - already handled with "FREE" badge<br />
2. '''Items with no discount''' (<code>price_list_rate == rate</code>) - no change needed<br />
3. '''Additional discount on total''' (<code>doc.discount_amount</code>) - show separately<br />
4. '''Multiple pricing rules per item''' - show highest or combined<br />
5. '''Margin-based pricing''' - <code>rate_with_margin</code> field<br />
<br />
== Related Documentation ==<br />
<br />
- [Webshop-13-Discount-Visibility-and-Urgency Chapter 13: Discount Visibility & Urgency] - UI specifications<br />
- [Webshop-14-Hypothesis-Discount-Deadline-Visibility Chapter 14: Hypothesis - Discount Deadline Visibility] - Exact implementation plan<br />
<br />
----<br />
<br />
'''Navigation:''' [Webshop-Index Webshop Index] | [Webshop-09-Hooks-and-Events Previous: 09 - Hooks & Events] | [Webshop-11-Feature-Plan-System-Builder Next: 11 - System Builder]</div>
Justinaquino